[PATCH] D74686: [NFC][mlir] Adding more operators to EDSC TemplatedIndexedValue

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 00:56:14 PST 2020


ftynse added inline comments.


================
Comment at: mlir/include/mlir/EDSC/Builders.h:600
+
+  ValueHandle operator==(ValueHandle e);
+  ValueHandle operator!=(ValueHandle e);
----------------
Could we have some block comments here? In particular, separating the two groups of operators (taking ValueHandle and taking TemplatedIndexedValue).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74686/new/

https://reviews.llvm.org/D74686





More information about the llvm-commits mailing list