[PATCH] D74527: AMDGPU/GlobalISel: Support llvm.trap intrinsic

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

In D74527#1878248 <https://reviews.llvm.org/D74527#1878248>, @arsenm wrote:

> In D74527#1878103 <https://reviews.llvm.org/D74527#1878103>, @hsmhsm wrote:
>
> > Based on the review comments by arsenm, I have moved handling of trap and debugtrap intrinsics to Legazizer, and submitted a new Phabricator review request - https://reviews.llvm.org/D74688.  Hence closing this review request.
>
>
> You could also have just updated this one with a new diff, instead of creating a separate review. Splitting the review usually makes it harder to track


Yes, I definitely agree. That is the right way to make any review changes. I initially thought of doing the same. But, later created new review because I thought of handling both trap and debug-trap intrinsics together. I will avoid it in next time on-wards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74527/new/

https://reviews.llvm.org/D74527