[PATCH] D73826: [mlir][Linalg] Provide a Tablegen backend to specify named Linalg ops declaratively

Sun Feb 16 14:10:38 PST 2020

nicolasvasilache added a comment.

In D73826#1877588 <https://reviews.llvm.org/D73826#1877588>, @mehdi_amini wrote:

> > Is there a world in which we can have such an Einsum-based parser on textual format to specify Linalg ops?
> >  Does this have to be a language outside of MLIR? (I would certainly hope not).
>
> I don't understand how these two questions can go together as they seem entirely disconnected to me, so I'm probably not understanding the questions in the first place :)
>
> > I think https://reviews.llvm.org/D73405 sets a nice precedent and I would very much want to see something like this for specifying Linalg ops declaratively.
>
> The main reason I have been reluctant to move on here is exactly because I would very much want to see something like this for specifying Linalg ops declaratively!
>  Where "something like this" is a feature that is generic enough to generalize and be reused across dialects, like D73405 <https://reviews.llvm.org/D73405>  :)

Ok so if we agree on the principle I think this is a great start then.
My main concern is a cost benefit tradeoff: I am super interested in the result of this but do not have the background or resources to do it in a way that is portable and reusable across dialects. It still took me an inordinate amount of time to get to what you see here: this is not my area of expertise.
However I did start talking about this to various folks more than 3 months ago but everyone is very busy and it has reached a point where it is blocking.
So I went ahead to move the needle.

Is it acceptable to move this in a new binary say ‘linalg-named-opgen-dontlookhowugly-pleasehelpimprove” so I am not blocked. When the right people have cycles and they see the end result they can start lending a hand.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73826/new/

https://reviews.llvm.org/D73826