[PATCH] D74693: [IRBuilder] Delete copy constructor

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/lib/IR/DIBuilder.cpp:900-903
+class IRBuilderForDbg : public IRBuilder<> {
+public:
+  IRBuilderForDbg(const DILocation *DL, BasicBlock *InsertBB,
+                  Instruction *InsertBefore)
----------------
Subclassing does not feel like the right approach for this (we might think about marking `IRBuilder` as final). It's just preconfiguring an IRBuilder. Standard technique would be to return a `unique_ptr<IRBuilder>` instead.

However, subclassing is more pragmatic here. Other opinions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74693/new/

https://reviews.llvm.org/D74693