[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D74691#1878373 <https://reviews.llvm.org/D74691#1878373>, @uenoku wrote:

> I'm not sure whether we can say if all the loops given by `LoopInfo` have a max trip count and all the callees are `willreturn`, then we can guarantee the termination of that function.


We can not. But if all cycles in the CFG are loops recognized by loop info and they have a max trip count we are good (in this part), I think.

> Aren't there other factors causing non-terminating execution?

Yes, calls to non-willreturn functions. That is handled in the updateImpl though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691