[PATCH] D74661: AMDGPU/GlobalISel: Insert readfirstlane on SGPR returns
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 16 07:16:30 PST 2020
arsenm added a comment.
In D74661#1878110 <https://reviews.llvm.org/D74661#1878110>, @nhaehnle wrote:
> Please remove the changes in the bswap test. It is critically important that we do not insert unnecessary v_readfirstlane insructions. Mesa performance leans on this quite heavily.
This is just noise for the purpose of the bswap test. We already fold out unneeded. readfirstlanes in 3 different places which already have tests. I’m also planning on adding another in the regbank aware combiner
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74661/new/
https://reviews.llvm.org/D74661
More information about the llvm-commits
mailing list