[PATCH] D74584: [mlir] Refactor TypeConverter to add conversions without inheritance

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Transforms/DialectConversion.h:177
+      if (Optional<Type> resultOpt = callback(type)) {
+        if (resultOpt && resultOpt.getValue())
+          results.push_back(resultOpt.getValue());
----------------
ftynse wrote:
> checking `resultOp` for being non-null is redundant here, the `if` the previous line ensured that
Thanks! Merged two functions together and missed updating this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74584/new/

https://reviews.llvm.org/D74584