[llvm] a8f0396 - [NFC] Revert unnecessary parts of b91c267380

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 23:43:45 PST 2020


Author: Johannes Doerfert
Date: 2020-02-15T01:38:58-06:00
New Revision: a8f039632d6f4d78a1304028df027cd4d0176535

URL: https://github.com/llvm/llvm-project/commit/a8f039632d6f4d78a1304028df027cd4d0176535
DIFF: https://github.com/llvm/llvm-project/commit/a8f039632d6f4d78a1304028df027cd4d0176535.diff

LOG: [NFC] Revert unnecessary parts of b91c267380

In b91c267380 I accidentally introduced fixes that were not necessary
after 1a93285c686a. All but the `llvm_unreachable` are reverted again.

Added: 
    

Modified: 
    llvm/lib/Frontend/OpenMP/OMPContext.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Frontend/OpenMP/OMPContext.cpp b/llvm/lib/Frontend/OpenMP/OMPContext.cpp
index d9db6318f9f5..62e5d1d8c466 100644
--- a/llvm/lib/Frontend/OpenMP/OMPContext.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPContext.cpp
@@ -412,7 +412,7 @@ bool llvm::omp::isValidTraitPropertyForTraitSetAndSelector(
 std::string llvm::omp::listOpenMPContextTraitSets() {
   std::string S;
 #define OMP_TRAIT_SET(Enum, Str)                                               \
-  if (!StringRef(Str).equals("invalid"))                                       \
+  if (StringRef(Str) != "invalid")                                             \
     S.append("'").append(Str).append("'").append(" ");
 #include "llvm/Frontend/OpenMP/OMPKinds.def"
   S.pop_back();
@@ -422,7 +422,7 @@ std::string llvm::omp::listOpenMPContextTraitSets() {
 std::string llvm::omp::listOpenMPContextTraitSelectors(TraitSet Set) {
   std::string S;
 #define OMP_TRAIT_SELECTOR(Enum, TraitSetEnum, Str, ReqProp)                   \
-  if (TraitSet::TraitSetEnum == Set && !StringRef(Str).equals("invalid"))      \
+  if (TraitSet::TraitSetEnum == Set && StringRef(Str) != "Invalid")            \
     S.append("'").append(Str).append("'").append(" ");
 #include "llvm/Frontend/OpenMP/OMPKinds.def"
   S.pop_back();
@@ -436,7 +436,7 @@ llvm::omp::listOpenMPContextTraitProperties(TraitSet Set,
 #define OMP_TRAIT_PROPERTY(Enum, TraitSetEnum, TraitSelectorEnum, Str)         \
   if (TraitSet::TraitSetEnum == Set &&                                         \
       TraitSelector::TraitSelectorEnum == Selector &&                          \
-      !StringRef(Str).equals("invalid"))                                       \
+      StringRef(Str) != "invalid")                                             \
     S.append("'").append(Str).append("'").append(" ");
 #include "llvm/Frontend/OpenMP/OMPKinds.def"
   S.pop_back();


        


More information about the llvm-commits mailing list