[PATCH] D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/AArch64.cpp:607
   btiEntry = btiHeader && !config->shared;
-  pacEntry = (config->andFeatures & GNU_PROPERTY_AARCH64_FEATURE_1_PAC);
+  pacEntry = config->pacPlt;
 
----------------
Unless I missed something, this change is not needed


================
Comment at: lld/ELF/SyntheticSections.cpp:1404
       addInt(DT_AARCH64_BTI_PLT, 0);
-    if (config->andFeatures & GNU_PROPERTY_AARCH64_FEATURE_1_PAC)
+    if (config->pacPlt)
       addInt(DT_AARCH64_PAC_PLT, 0);
----------------
Unless I missed something, this change is not needed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74537/new/

https://reviews.llvm.org/D74537