[PATCH] D74531: [WebAssembly] Emit PCH __clang_ast in custom section

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 15:34:32 PST 2020


sbc100 added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1701
+  if (Name == "__clangast")
+    return SectionKind::getMetadata();
+
----------------
sbc100 wrote:
> Hmm.. it looks like this function isn't actually needed: https://reviews.llvm.org/D74565.
> 
> Does this change work if you simply `return K` here?   I guess/hope it does.
Let me know if this change is uneeded with  https://reviews.llvm.org/D74565.?  I'll hold of landing that until I hear back.  Hopefully it will just work and simplify this patch once it lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74531/new/

https://reviews.llvm.org/D74531





More information about the llvm-commits mailing list