[PATCH] D51664: [IR] Lazily number instructions for local dominance queries

[River Riddle via Phabricator via llvm-commits]

rriddle added a comment.

In D51664#1877032 <https://reviews.llvm.org/D51664#1877032>, @rnk wrote:

> I meant to add that @rriddle adopted this approach in MLIR:
>  https://github.com/llvm/llvm-project/blob/master/mlir/include/mlir/IR/Operation.h#L615


Yes, we've been using this in MLIR for at least a year now. There have been quite a few cases in MLIR, unrelated to DSE, that have really benefited from O(1) dominance checks readily available. There has only been one situation that I can recall where recomputing the block order showed up on a profile, but adding in some basic striding to the order assignment completely fixed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51664/new/

https://reviews.llvm.org/D51664