[PATCH] D68899: llvm/cmake/config.guess: add support for riscv32 and riscv64

Fri Feb 14 12:57:48 PST 2020

Meinersbur added a comment.

In D68899#1872251 <https://reviews.llvm.org/D68899#1872251>, @luismarques wrote:

> In D68899#1872213 <https://reviews.llvm.org/D68899#1872213>, @gokturk wrote:
>
> > The current config.guess is GPL-2 or later. The upstream config.guess is GPL-3. I was under the impression that LLVM upstream wanted to maintain a GPL-2 license. So I wrote my own version.
>
>
> I also thought that might be a problem, but there are two more `config.guess` files in the monorepo, and one of them is GPL-3 (`polly/lib/External/isl/config.guess`), but maybe that's not considered core to LLVM enough to matter? I'm not sure to what extent a configure script is considered to affect the general LLVM license...

That files comes from creating a distribution of ISL, using whatever version of autoconf is on the system. It contains the following passage:

  # As a special exception to the GNU General Public License, if you
  # distribute this file as part of a program that contains a
  # configuration script generated by Autoconf, you may include it under
  # the same distribution terms that you use for the rest of that
  # program.  This Exception is an additional permission under section 7
  # of the GNU General Public License, version 3 ("GPLv3").

This file is not used since we re-created the build system using cmake. I could remove it if deemed necessary.

By contrast, I am more surprised that we slapped a Apache-2 license on ConvertUTF.cpp/.h and nobody seem to care: D66390 <https://reviews.llvm.org/D66390>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68899/new/

https://reviews.llvm.org/D68899