[PATCH] D74143: [MLIR] Adding attribute setters generation for table gen
Alexandre Eichenberger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 14 12:30:55 PST 2020
AlexEichenberger marked an inline comment as done.
AlexEichenberger added inline comments.
================
Comment at: mlir/test/mlir-tblgen/op-attribute.td:64
+// DEF-NEXT: this->setAttr("cAttr", attr);
+
// Test build methods
----------------
mehdi_amini wrote:
> It is a bit annoying that a setters isn't prefixed with `set`: in general I rather have method starting with a verb expressing their actions. (This is also the general style in MLIR I believe).
>
> That said we already emit the getters without a `get` similarly, so this is in line with what is already there.
>
Would you like me to add the set, e.g. setPadAttr(...) or leave the proposal as is?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74143/new/
https://reviews.llvm.org/D74143
More information about the llvm-commits
mailing list