[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 10:48:57 PST 2020


dcaballe added a comment.
Herald added a reviewer: herhut.

Thanks for addressing this so quickly and for the feedback! I'm giving it a try. Re reverting patches, this is a very common practice. Sometimes patches are reverted without giving an opportunity to provide a fix. It shouldn't be a problem. LLVM has a no regression policy and testing goes beyond in-tree tests since many vendors have private forks. In any case, I just provided some options so that you could decide. Thanks again for addressing this so quickly!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211





More information about the llvm-commits mailing list