[PATCH] D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions
Jin Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 14 10:39:41 PST 2020
jinlin added a comment.
> Also, I guess it would also be good to add a testcase that ensures that a register is //not// added as implicit when it's undefined in the range.
Hi Jessica,
The logic at line 1275 will not introduce any new stability issue compared to the existing compiler since the existing compiler does not generate any implicit use of registers. That is why I think it is fine not to have a test case for this. What do you think?
--Jin
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71217/new/
https://reviews.llvm.org/D71217
More information about the llvm-commits
mailing list