[PATCH] D74614: [CSInfo][TailDuplicator] Update the call site info

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:867
+        MF->eraseCallSiteInfo(&MI);
+    });
+
----------------
vsk wrote:
> Why is this change necessary? I think this part of `tailDuplicate` just duplicates the contents of TailBB into PredBB. The deletion doesn't look like it happens until we get back to `tailDuplicateAndUpdate`, in `removeDeadBlock`.
> 
> If anything I'd expect that we'd have to `copyCallSiteInfo` here. I'll dig into this some more, I easily might be missing something.
I think this won’t get into the removeDeadBlock part in some situations for particular calls. Probably we should use move* or copy* method here... I was struggling with making a test case for this, and had not payed enough attention on this part. I’ll double check this as well. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74614/new/

https://reviews.llvm.org/D74614