[PATCH] D74448: [scudo][standalone] Allow setting release to OS

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:631
+    if (O == Option::PrimaryReleaseInterval) {
+      Primary.setReleaseToOsIntervalMs(Value);
+      return true;
----------------
`error: conversion from  ‘scudo::sptr’ {aka ‘long int’} to ‘scudo::s32’ {aka ‘int’} may change value [-Werror=conversion]`
so `static_cast` to `s32`.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:634
+    } else if (O == Option::SecondaryReleaseInterval) {
+      Secondary.setReleaseToOsIntervalMs(Value);
+      return true;
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74448/new/

https://reviews.llvm.org/D74448