[PATCH] D74420: [Assembler] Emit summary index flags

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 updated this revision to Diff 244659.
evgeny777 added a comment.

Addressed comments

> Looking at SlotTracker::processIndex, I think it could be improved and we can compute this there. For clarity, that method should probably iterate the typeIdCompatibleVtableMap before setting TypeIdNext (although the typeIdCompatibleVtable and the typeId summaries are mutually exclusive, I think it would be clearer to do it in that order). Then we could add something like a "IndexSlot" variable that can be set to TypeIdNext at the end.

Makes sense but I don't think we need an extra variable. We can simply use TypeIdNext, as it will be equal to number of slots in both combined and per-module summaries.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74420/new/

https://reviews.llvm.org/D74420

Files:
  llvm/include/llvm/IR/ModuleSummaryIndex.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/AsmParser/LLParser.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/IR/ModuleSummaryIndex.cpp
  llvm/test/Assembler/summary-flags.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74420.244659.patch
Type: text/x-patch
Size: 9994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200214/68c0d000/attachment.bin>