[llvm] 2102ef8 - Reenable "Always import constants" after compile time fixes

[Teresa Johnson via llvm-commits]

Author: Teresa Johnson
Date: 2020-02-14T06:37:14-08:00
New Revision: 2102ef8aad4ca0782cdac316afc8d306b04582c4

URL: https://github.com/llvm/llvm-project/commit/2102ef8aad4ca0782cdac316afc8d306b04582c4
DIFF: https://github.com/llvm/llvm-project/commit/2102ef8aad4ca0782cdac316afc8d306b04582c4.diff

LOG: Reenable "Always import constants" after compile time fixes

Summary:
Reenables importing of constants by default, which was disabled in
D73724 due to excessive thin link times. These inefficiencies were
fixed in D73851.

I re-measured thin link times for a number of binaries that had compile
time explosions with importing of constants previously and confirmed
they no longer have any notable increases with it enabled.

Reviewers: wmi, evgeny777

Subscribers: hiraditya, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74512

Added: 
    

Modified: 
    llvm/lib/IR/ModuleSummaryIndex.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/ModuleSummaryIndex.cpp b/llvm/lib/IR/ModuleSummaryIndex.cpp
index 0a43e17c358c..d92943d6975b 100644
--- a/llvm/lib/IR/ModuleSummaryIndex.cpp
+++ b/llvm/lib/IR/ModuleSummaryIndex.cpp
@@ -31,10 +31,8 @@ static cl::opt<bool> PropagateAttrs("propagate-attrs", cl::init(true),
                                     cl::Hidden,
                                     cl::desc("Propagate attributes in index"));
 
-// FIXME: Enable again when thin link compile time regressions understood and
-// addressed
 static cl::opt<bool> ImportConstantsWithRefs(
-    "import-constants-with-refs", cl::init(false), cl::Hidden,
+    "import-constants-with-refs", cl::init(true), cl::Hidden,
     cl::desc("Import constant global variables with references"));
 
 FunctionSummary FunctionSummary::ExternalNode =