[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added a comment.

Thanks Maskray for your comment regarding marking comments as "done", I'll look out for that in future.



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1116
+                 SmallVector<const char *, 0> Args) {
+  StringRef Arg = removeHyphens(*ArgIt);
+  size_t len = Expected.size();
----------------
gbreynoo wrote:
> MaskRay wrote:
> > `removeHyphens` is only used once. Consider inlining it.
> > 
> > I feel a bit strange about removeHyphens. Does it accept an option without a dash?
> I have inlined the function..
Regarding the your question, the removeHyphens  function would accept options without a dash and return the same value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665