[PATCH] D74477: [llvm-ar] Simplify Windows comparePaths NFCI

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 04:34:37 PST 2020


andrewng added a comment.

In D74477#1875164 <https://reviews.llvm.org/D74477#1875164>, @amccarth wrote:

> Just curious:  Do we know that the paths stored in the archive are actually UTF-8 and not just MBCS using whatever code page the user had when they created the archive?


I don't believe that this is well defined as far as any "ar"  file format standard is concerned. However, llvm-ar does make the assumption of UTF-8 encoding and it's command line input's are in UTF-8. This is probably the only sensible default given that there is no indication of what code page a user might have been using.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74477/new/

https://reviews.llvm.org/D74477





More information about the llvm-commits mailing list