[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Support/ELFAttributeParser.h:1
+//===--- ELF AttributeParser.h - ELF Attribute Information Printer --------===//
+//
----------------
This is missing the language specifier.


================
Comment at: llvm/include/llvm/Support/RISCVAttributeParser.h:1
+//===--- RISCVAttributeParser.h - RISCV Attribute Information Printer -----===//
+//
----------------
This is missing the language specifier.


================
Comment at: llvm/lib/Support/ELFAttributeParser.cpp:44
+  StringRef TagName =
+      ELFBuildAttrs::AttrTypeAsString(Tag, TagToStringMap, /*TagPrefix*/ false);
+  uint64_t Value = ParseInteger(Data, Offset);
----------------
Use `/*TagPrefix=*/` - clang-format recognises this pattern and removes the space after it.


================
Comment at: llvm/lib/Support/ELFAttributeParser.cpp:60
+  StringRef TagName =
+      ELFBuildAttrs::AttrTypeAsString(Tag, TagToStringMap, /*TagPrefix*/ false);
+  StringRef Value = ParseString(Data, Offset);
----------------
Ditto.


================
Comment at: llvm/lib/Support/ELFAttributeParser.cpp:126
+void ELFAttributeParser::ParseSubsection(const uint8_t *Data, uint32_t Length) {
+  uint32_t Offset = sizeof(uint32_t); /* SectionLength */
+
----------------
Use C++ style comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023