[PATCH] D74401: [MLIR] Add std.atomic_rmw op

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.

LGTM when extra documentation is added as discussed on Discourse.



================
Comment at: mlir/include/mlir/Dialect/StandardOps/Ops.td:235
+    "atomic_rmw_yield" op, which is used to specify the new value that needs to
+    be stored.
+
----------------
Could you please describe the restrictions on the body contents of the atomic region as discussed in the RFC? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74401/new/

https://reviews.llvm.org/D74401