[PATCH] D74520: [mlir] [VectorOps] Initial framework for progressively lowering vector.contract

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Minor nits, approving conditionally.
Thanks Aart!



================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:364
       int64_t lhsDimIndex = getResultIndex(indexingMaps[0], targetExpr);
+      if (lhsDimIndex < 0) {
+        continue;
----------------
trivial braces


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:373
     int64_t resDimIndex = getResultIndex(indexingMaps[2], targetExpr);
+    if (resDimIndex < 0) {
+      continue;
----------------
trivial braces


================
Comment at: mlir/test/lib/Transforms/TestVectorTransforms.cpp:56
 
-static PassRegistration<TestVectorToVectorConversion>
-    pass("test-vector-to-vector-conversion",
-         "Test conversion patterns between ops in the vector dialect");
+static PassRegistration<TestVectorToVectorConversion> vector_to_vector_pass(
+    "test-vector-to-vector-conversion",
----------------
lowerCamelCase names here and below plz.
It seems we missed a beat with slicesPass in the past.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74520/new/

https://reviews.llvm.org/D74520