[PATCH] D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked an inline comment as done.
jmorse added inline comments.


================
Comment at: debuginfo-tests/dexter/dex/debugger/dbgeng/setup.py:93
+  # and WaitForEvent'ing means we should have reached that break state.
+  # Now set a breakpoint on the main symbol, and "go" until we reach it.
   module_name = Client.Symbols.get_exefile_module_name()
----------------
Orlando wrote:
> What happens if the timeout fails?
> 
> Does it make sense to have a similar snippet to the one found a couple lines down for another WaitForEvent:
> ```
>   if res == S_FALSE:
>     client.TerminateProcesses()
>     raise Exception("Debuggee did not reach main function in a timely manner")
> ```
> 
I guess it does, that's a better failure mode than the current situation, where calls will randomly fail with status 0x8000FFFF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74409/new/

https://reviews.llvm.org/D74409