[PATCH] D73339: [RISCV] Compress instructions based on function features
Simon Cook via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 13 02:49:04 PST 2020
simoncook added a comment.
In D73339#1872048 <https://reviews.llvm.org/D73339#1872048>, @luismarques wrote:
> It may be a bit of a hacky solution, but how about this? You keep one test file, add the attribute group references to the test functions, but don't add the attribute group definition to the source. Then in the RUN lines you `cat` the test source together with either an empty attribute group (the original tests) or the one with the target features.
That would work. Looking at other targets tests it looks like NVPTX uses this method to do something similar for adding metadata to tests (e.g. `test/CodeGen/NTPTX/nvvm-relfect.ll`), so I'll rebase this using this pattern to keep just one test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73339/new/
https://reviews.llvm.org/D73339
More information about the llvm-commits
mailing list