[PATCH] D73994: [InlineCost] Relax bonus restrictions on uninlinable functions

Gerolf Hoflehner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 12:15:11 PST 2020


Gerolf added subscribers: paquette, fhahn, aemerson, Gerolf.
Gerolf added a comment.

Especially for inliner changes I suggest a) sharing performance numbers on standard benchmarks with O2 <https://reviews.llvm.org/owners/package/2/> & O2 <https://reviews.llvm.org/owners/package/2/> (thin) LTO, and b) offering a flag to toggle individual changes.  Performance here includes run-time performance, compile-time, and code size. A simple change can have detrimental impact on any of key metrics folks might be watching, and that that impact could be different depending on the targets.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73994/new/

https://reviews.llvm.org/D73994





More information about the llvm-commits mailing list