[PATCH] D74488: [VFS] Fix vfsoverlay assertion due to RedirectingFileSystem path handling.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 11:47:00 PST 2020


amccarth added a comment.

> FileManager::FixupRelativePath uses path::append to append "." onto the working directory and gets "C:/work/example\." because path::append uses the preferred native separator which is "\"

This is where we diverge.  I'm getting a Windows-style working directory (`C:\work\example`), so appending the dot yields `C:\work\example\.`, and canonicalize handles that properly.

The working directory is initialized from the external filesystem.  On my machine, this is naturally in native host form.  In your case, something must be changing it to the (forward) slash form.

Still investigating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74488/new/

https://reviews.llvm.org/D74488





More information about the llvm-commits mailing list