[PATCH] D74477: [llvm-ar] Simplify Windows comparePaths NFCI
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 13 10:33:45 PST 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
So, I don't see how adjusting the UNC handling in widenPath will matter. If the two strings are equal, widenPath should probably treat them the same, and add the UNC prefix to LHS iff it does to RHS. But, the UNC handling is clearly unnecessary to do a simple case insensitive string comparison, so this change seems correct even if UNC handling were not an issue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74477/new/
https://reviews.llvm.org/D74477
More information about the llvm-commits
mailing list