[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

Thu Feb 13 10:06:04 PST 2020

aprantl added a comment.

In D74470#1873714 <https://reviews.llvm.org/D74470#1873714>, @Chirag wrote:

> In D74470#1872492 <https://reviews.llvm.org/D74470#1872492>, @probinson wrote:
>
> > D73261 <https://reviews.llvm.org/D73261> would also benefit from moving more flags into the subprogram flags field.  The refactoring really should move out as many flags as possible all in one go.  I understand this is more than you anticipated but it will be the right thing to do for the project as a whole.
>
>
> I can create a separate small patches for other flags DIVarFlags/Mod DISPFlag it will be easier to track if something gets broken. (i am not fully aware of all the flags' complete use cases)

While we usually always prefer the smallest possible patches for reviews, for moving attributes from one field to another in a bitcode-incompatible way, it would be better to move them in bulk, indicated by a single "version" bit in the bitcode encoding.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74470/new/

https://reviews.llvm.org/D74470