[PATCH] D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

[Cristian Adam via Phabricator via llvm-commits]

cristian.adam created this revision.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
cristian.adam added reviewers: zturner, mstorsjo.

MSVC_DIA_SDK_DIR variable will point to a path which contains spaces, and without quotes it will fail to configure the project.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74561

Files:
  llvm/cmake/config-ix.cmake


Index: llvm/cmake/config-ix.cmake
===================================================================
--- llvm/cmake/config-ix.cmake
+++ llvm/cmake/config-ix.cmake
@@ -469,7 +469,7 @@
   # though that we should handle it.  We do so by simply checking that
   # the DIA SDK folder exists.  Should this happen you will need to
   # uninstall VS 2012 and then re-install VS 2013.
-  if (IS_DIRECTORY ${MSVC_DIA_SDK_DIR})
+  if (IS_DIRECTORY "${MSVC_DIA_SDK_DIR}")
     set(HAVE_DIA_SDK 1)
   else()
     set(HAVE_DIA_SDK 0)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74561.244438.patch
Type: text/x-patch
Size: 521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200213/65073399/attachment.bin>