[PATCH] D74536: [VE] Support for PIC (global data and calls)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/VEAsmPrinter.cpp:210
+  case MachineOperand::MO_ConstantPoolIndex:
+    report_fatal_error("ConstantPool is not supporeted yet");
+    return;
----------------
Typo supporeted repeated a few times


================
Comment at: llvm/lib/Target/VE/VEISelDAGToDAG.cpp:135
+SDNode *VEDAGToDAGISel::getGlobalBaseReg() {
+  unsigned GlobalBaseReg = Subtarget->getInstrInfo()->getGlobalBaseReg(MF);
+  return CurDAG
----------------
s/unsigned/Register


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:697-699
+    if (dyn_cast<ConstantPoolSDNode>(Op) != nullptr ||
+        (dyn_cast<GlobalAddressSDNode>(Op) != nullptr &&
+         dyn_cast<GlobalAddressSDNode>(Op)->getGlobal()->hasLocalLinkage())) {
----------------
use the dyn_cast value instead of checking and dyn_casting again


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.h:79
 
+  unsigned getGlobalBaseReg(MachineFunction *MF) const;
+
----------------
s/unsigned/Register


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74536/new/

https://reviews.llvm.org/D74536