[PATCH] D74525: [mlir][DeclarativeParser] Add support for formatting enum attributes in the string form.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added a comment.
This revision is now accepted and ready to land.

Nice! Thanks River for adding support for this!



================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:301
+    auto loc = parser.getCurrentLocation();
+    if (parser.parseAttribute(attrVal, parser.getBuilder().getNoneType(),
+                              "{0}", attrStorage))
----------------
Do we want to specify none type here? It should parse as a string attr for start and we later reply on that for symbolize the string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74525/new/

https://reviews.llvm.org/D74525