[PATCH] D74522: [X86] Don't widen 128/256-bit strict compares with vXi1 result to 512-bits on KNL.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

This is my first view of these test files, so it might just be me...but I didn't inspect every test diff. It looks like we're brute-forcing through a matrix of {x preds, y data types, (non)signalling, 32/64-bit targets, ... }. I'd interleave those parameters to reduce the number of tests by 8-16x or more. Save test and review time if we're pretty confident that the lowering logic is fairly uniform. :)



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:21760
+      // If this is SSE/AVX CMPP, bitcast the result back to integer to match
+      // the // result type of SETCC. The bitcast is expected to be optimized
+      // away during combining/isel.
----------------
Extra // in re-flowed comment text.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74522/new/

https://reviews.llvm.org/D74522