[PATCH] D74546: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 13 06:26:38 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5ee4a03bc916: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours (authored by jmorse).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74546/new/
https://reviews.llvm.org/D74546
Files:
debuginfo-tests/dexter/dex/debugger/Debuggers.py
debuginfo-tests/dexter/dex/tools/test/Tool.py
debuginfo-tests/lit.cfg.py
Index: debuginfo-tests/lit.cfg.py
===================================================================
--- debuginfo-tests/lit.cfg.py
+++ debuginfo-tests/lit.cfg.py
@@ -104,7 +104,7 @@
'dexter', 'dexter.py')
dexter_test_cmd = '"{}" "{}" test'.format(config.python3_executable, dexter_path)
if lldb_path is not None:
- dexter_test_cmd += ' --lldb-executable {}'.format(lldb_path)
+ dexter_test_cmd += ' --lldb-executable "{}"'.format(lldb_path)
tools.append(ToolSubst('%dexter', dexter_test_cmd))
# For testing other bits of dexter that aren't under the "test" subcommand,
Index: debuginfo-tests/dexter/dex/tools/test/Tool.py
===================================================================
--- debuginfo-tests/dexter/dex/tools/test/Tool.py
+++ debuginfo-tests/dexter/dex/tools/test/Tool.py
@@ -58,7 +58,7 @@
if self.error:
script_error = (' : {}'.format(
- self.error.script_error.splitlines()[0].decode()) if getattr(
+ self.error.script_error.splitlines()[0]) if getattr(
self.error, 'script_error', None) else '')
error = ' [{}{}]'.format(
Index: debuginfo-tests/dexter/dex/debugger/Debuggers.py
===================================================================
--- debuginfo-tests/dexter/dex/debugger/Debuggers.py
+++ debuginfo-tests/dexter/dex/debugger/Debuggers.py
@@ -41,7 +41,7 @@
def _warn_meaningless_option(context, option):
- if context.options.list_debuggers:
+ if hasattr(context.options, 'list_debuggers'):
return
warn(context,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74546.244416.patch
Type: text/x-patch
Size: 1600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200213/5b084e2a/attachment.bin>
More information about the llvm-commits
mailing list