[PATCH] D74545: [llvm-readobj] - Refactor the code that dumps relocations.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 05:50:08 PST 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5737
                                       const Elf_Shdr *SymTab) {
+  const typename ELFT::Sym *Sym;
+  std::string TargetName;
----------------
I've realized that `Sym` variable is not used for LLVMStyle.
(And a warning was not reported because of `std::tie` it seems).
Will update diff after finishing with the follow-up patch for this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74545/new/

https://reviews.llvm.org/D74545





More information about the llvm-commits mailing list