[PATCH] D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 05:31:25 PST 2020


Orlando added inline comments.


================
Comment at: debuginfo-tests/dexter/dex/utils/WorkingDirectory.py:46
+
+        self.context.o.yellow('Warning: "{}" left in place [couldn\'t delete]\n'.format(self.path))
+        return
----------------
In `Warning.py` there's a warning wrapper function `warn(context, msg, flag=None)`. I think we should use that for consistency (it checks if the user has disabled warnings)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74548/new/

https://reviews.llvm.org/D74548





More information about the llvm-commits mailing list