[PATCH] D74543: [MLIR][Affine] Mark affine.min and affine.max as NoSideffect.

[Stephan Herhut via Phabricator via llvm-commits]

herhut created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

The operation has no sideffects and it was probably just an oversight
that the trait is missing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74543

Files:
  mlir/include/mlir/Dialect/AffineOps/AffineOps.td


Index: mlir/include/mlir/Dialect/AffineOps/AffineOps.td
===================================================================
--- mlir/include/mlir/Dialect/AffineOps/AffineOps.td
+++ mlir/include/mlir/Dialect/AffineOps/AffineOps.td
@@ -235,7 +235,7 @@
 }
 
 class AffineMinMaxOpBase<string mnemonic, list<OpTrait> traits = []> :
-    Op<Affine_Dialect, mnemonic, traits> {
+    Op<Affine_Dialect, mnemonic, !listconcat(traits, [NoSideEffect])> {
   let arguments = (ins AffineMapAttr:$map, Variadic<Index>:$operands);
   let results = (outs Index);
   let extraClassDeclaration = [{


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74543.244387.patch
Type: text/x-patch
Size: 581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200213/d06342bf/attachment.bin>