[PATCH] D74368: [TBLGEN] Fix subreg value overflow in DAGISelMatcher

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/utils/TableGen/DAGISelMatcherGen.cpp:725
+        StringRef Name = Def->getName();
+        const CodeGenSubRegIndex *I = RB.lookupSubRegIndex(Name);
+        assert(I && "Cannot find subreg index by name!");
----------------
arsenm wrote:
> Actually, why do you need to do the name lookup at all? Can't you juts do CodeGenRegBank.getSubRegIdx(Def)?
I had to create another function which just lookups the map by Def, as CGP is constant. But you are right, string lookup was not needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74368/new/

https://reviews.llvm.org/D74368