[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

Wed Feb 12 23:38:27 PST 2020

djtodoro added a comment.

Anyhow, moving other flags should be a different revision (should not be part of this one), so with the comments addressed, this looks good to me. :)

================
Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:105

+// BasicType flags kept in DIBasicType
+
----------------
`.` at the end of the comment

================
Comment at: llvm/test/Bitcode/DIBasicType.ll:27
+!8 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed, btFlags: DIBTFlagBigEndian)
+!9 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed, btFlags: DIBTFlagLittleEndian)
+!10 = !{i32 7, !"Dwarf Version", i32 4}
----------------
aprantl wrote:
> Assuming that the IR in this file is the input for `DIBasicType.ll.bc`, I would have expected this to use the *old* format to test that the old format can be upgraded to the new format. The assembler roundtrip test `debug-info.ll` is already testing that the new format works.
+1

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74470/new/

https://reviews.llvm.org/D74470