[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram marked an inline comment as done.
tmsriram added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1627
+
+      const auto *InputSec = dyn_cast<InputSectionBase>(Sec->repl);
+      if (!InputSec || !InputSec->BytesDropped)
----------------
MaskRay wrote:
> If you use `sec->repl`, there should be tests checking --icf={safe,all}
I added an icf all test for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065