[PATCH] D68065: Propeller: LLD Support for Basic Block Sections
Sriraman Tallam via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 12 16:40:42 PST 2020
tmsriram added inline comments.
================
Comment at: lld/ELF/Arch/X86_64.cpp:169
+
+static bool isDirectJmpInsnOpcode(const uint8_t *Opcode) {
+ return (*Opcode == 0xe9);
----------------
ruiu wrote:
> Does "direct jmp" actually mean just J_JMP_32?
Yes, it is J_JMP_32. Do you want this refactored into getJmpInsnType?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68065/new/
https://reviews.llvm.org/D68065
More information about the llvm-commits
mailing list