[PATCH] D74488: [VFS] Fix vfsoverlay assertion due to RedirectingFileSystem path handling.

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

Thanks for the extra info!

On my machine I'm seeing the same issue with the sed lines generating bad path syntax, yet the test still passes!  (And, yes, assertions are enabled.)

I'd like to be able to repro the problem before blessing any particular fix.

Is it possible your build bot isn't consistently synced?

  D:\src\llvm\build\ninja_dbg>python bin/llvm-lit.py -v -vv -a tools/clang/test/ClangScanDeps/vfsoverlay.cpp
  llvm-lit.py: D:/src/llvm/llvm-project/llvm\utils\lit\lit\llvm\config.py:342: note: using clang: d:\src\llvm\build\ninja_dbg\bin\clang.exe
  -- Testing: 1 tests, 1 workers --
  PASS: Clang :: ClangScanDeps/vfsoverlay.cpp (1 of 1)
  Script:
  --
  : 'RUN: at line 1';   rm -rf D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir
  : 'RUN: at line 2';   rm -rf D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.cdb
  : 'RUN: at line 3';   mkdir -p D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir
  : 'RUN: at line 4';   cp D:\src\llvm\llvm-project\clang\test\ClangScanDeps\vfsoverlay.cpp D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir/vfsoverlay_input.cpp
  : 'RUN: at line 5';   sed -e "s|DIR|D:/src/llvm/build/ninja_dbg/tools/clang/test/ClangScanDeps/Output/vfsoverlay.cpp.tmp.dir|g" D:\src\llvm\llvm-project\clang\test\ClangScanDeps/Inputs/vfsoverlay.yaml > D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir/vfsoverlay.yaml
  : 'RUN: at line 6';   mkdir D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir/Inputs
  : 'RUN: at line 7';   cp D:\src\llvm\llvm-project\clang\test\ClangScanDeps/Inputs/header.h D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.dir/Inputs/header.h
  : 'RUN: at line 8';   sed -e "s|DIR|D:/src/llvm/build/ninja_dbg/tools/clang/test/ClangScanDeps/Output/vfsoverlay.cpp.tmp.dir|g" D:\src\llvm\llvm-project\clang\test\ClangScanDeps/Inputs/vfsoverlay_cdb.json > D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.cdb
  : 'RUN: at line 10';   clang-scan-deps -compilation-database D:\src\llvm\build\ninja_dbg\tools\clang\test\ClangScanDeps\Output\vfsoverlay.cpp.tmp.cdb -j 1 |    d:\src\llvm\build\ninja_dbg\bin\filecheck.exe D:\src\llvm\llvm-project\clang\test\ClangScanDeps\vfsoverlay.cpp
  --
  Exit Code: 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74488/new/

https://reviews.llvm.org/D74488