[PATCH] D74512: Reenable "Always import constants" after compile time fixes

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson created this revision.
tejohnson added reviewers: wmi, evgeny777.
Herald added subscribers: arphaman, hiraditya.
Herald added a project: LLVM.

Reenables importing of constants by default, which was disabled in
D73724 <https://reviews.llvm.org/D73724> due to excessive thin link times. These inefficiencies were
fixed in D73851 <https://reviews.llvm.org/D73851>.

I re-measured thin link times for a number of binaries that had compile
time explosions with importing of constants previously and confirmed
they no longer have any notable increases with it enabled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74512

Files:
  llvm/lib/IR/ModuleSummaryIndex.cpp


Index: llvm/lib/IR/ModuleSummaryIndex.cpp
===================================================================
--- llvm/lib/IR/ModuleSummaryIndex.cpp
+++ llvm/lib/IR/ModuleSummaryIndex.cpp
@@ -31,10 +31,8 @@
                                     cl::Hidden,
                                     cl::desc("Propagate attributes in index"));
 
-// FIXME: Enable again when thin link compile time regressions understood and
-// addressed
 static cl::opt<bool> ImportConstantsWithRefs(
-    "import-constants-with-refs", cl::init(false), cl::Hidden,
+    "import-constants-with-refs", cl::init(true), cl::Hidden,
     cl::desc("Import constant global variables with references"));
 
 FunctionSummary FunctionSummary::ExternalNode =


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74512.244291.patch
Type: text/x-patch
Size: 725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200212/637646e9/attachment.bin>