[PATCH] D74364: [GWP-ASan] Update alignment on Android.

Wed Feb 12 15:27:12 PST 2020

hctim marked 2 inline comments as done.
hctim added inline comments.

================
Comment at: compiler-rt/lib/gwp_asan/tests/alignment.cpp:29
+      {1, 8},   {2, 8},   {3, 8},       {4, 8},       {5, 8},   {7, 8},
+      {8, 8},   {9, 16},  {15, 16},     {16, 16},     {17, 24}, {31, 32},
+      {32, 32}, {33, 40}, {4095, 4096}, {4096, 4096},
----------------
morehouse wrote:
> Nit:  we technically don't care about alignments >16, so why test for them?  (same for PowerOfTwo test)
We're not testing the alignment here, it's actually the mapping between `asked size => real (aligned) size`. Let me update the variable names to make this more clear.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74364/new/

https://reviews.llvm.org/D74364