[PATCH] D74510: [ELF] Fix a null pointer dereference when --emit-relocs and --strip-debug are used together

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 15:09:23 PST 2020


nickdesaulniers added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1947
+    if (auto *isec = dyn_cast<InputSection>(s))
+      if (InputSectionBase *rel = isec->getRelocatedSection())
+        if (isDebugSection(rel))
----------------
will this fit on one line?
```
if (isDebugSection(isec->getRelocationSection())`
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74510/new/

https://reviews.llvm.org/D74510





More information about the llvm-commits mailing list