[PATCH] D70606: LLD: CET shadow stack support on Windows

[Petr Penzin via Phabricator via llvm-commits]

penzn added a comment.

Expanding on my previous comment. In its current state `yaml2obj` is not aware of the section contents, and I think adding this functionality would be a bit more involved than the code we have in this review so far.

Quick rundown of what would be needed for `yaml2obj` change:

- Define YAML syntax for debug entries
- Support debug directory and its contents inside section mapping in ObjectYAML
  - Need to represent the structure from Debug section down to individual debug records
- Change other tests which depend on debug directory structure

We should probably discuss details. For example, can debug directory support in ObjectYAML take inspiration from LLD or would that make testing moot? Would ObjectYAML need any tests for this new functionality?

Do you mind if we move ObjectYAML discussion elsewhere? What would be a good place for it, llvm-dev?

As for this change, another option is to use `yaml2obj`, but output debug directory as a hex section in the YAML file. However this would inconsistent with `codeview` tests, maybe it would be better to change everything at once when `yaml2obj` is ready.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70606/new/

https://reviews.llvm.org/D70606