[llvm] baf3a53 - [docs] Minor updates to DeveloperPolicy due to svn to git
Jinsong Ji via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 12 13:27:11 PST 2020
Author: Jinsong Ji
Date: 2020-02-12T21:08:15Z
New Revision: baf3a53b5750a0b1363248d45b0fa0cbda0253e1
URL: https://github.com/llvm/llvm-project/commit/baf3a53b5750a0b1363248d45b0fa0cbda0253e1
DIFF: https://github.com/llvm/llvm-project/commit/baf3a53b5750a0b1363248d45b0fa0cbda0253e1.diff
LOG: [docs] Minor updates to DeveloperPolicy due to svn to git
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D73971
Added:
Modified:
llvm/docs/DeveloperPolicy.rst
Removed:
################################################################################
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index c4d0ceb73c8e..883556fc9536 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -160,7 +160,7 @@ larger features. Accepted ways to speed up review times for your patches are:
Developers should participate in code reviews as both reviewers and
reviewees. If someone is kind enough to review your code, you should return the
favor for someone else. Note that anyone is welcome to review and give feedback
-on a patch, but only people with Subversion write access can approve it.
+on a patch, but only people with GitHub commit access can approve it.
There is a web based code review tool that can optionally be used
for code reviews. See :doc:`Phabricator`.
@@ -325,9 +325,9 @@ Below are some guidelines about the format of the message itself:
and in-code comments, ex. capitalization, full stop, etc.
* If the commit is a bug fix on top of another recently committed patch, or a
- revert or reapply of a patch, include the svn revision number of the prior
- related commit. This could be as simple as "Revert rNNNN because it caused
- PR#".
+ revert or reapply of a patch, include the git commit hash of the prior
+ related commit. This could be as simple as "Revert commit NNNN because it
+ caused PR#".
For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and
More information about the llvm-commits
mailing list