[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

Wed Feb 12 12:52:34 PST 2020

andreisfr marked an inline comment as done.
andreisfr added inline comments.

================
Comment at: llvm/test/Object/obj2yaml.test:734

+# RUN: obj2yaml %p/Inputs/trivial-object-test.elf-xtensa | FileCheck %s --check-prefix ELF-XTENSA
+
----------------
jhenderson wrote:
> andreisfr wrote:
> > jhenderson wrote:
> > > Rather than adding a pre-canned binary, use yaml2obj to generate a file.
> > You suggest to create separate obj2yaml test for Xtensa? 
> > Or add Xtensa ELF header yaml description in current file? I'm bother that  there is already X86 ELF yaml description in this file, so yaml2obj could produce wrong result while processing obj2yaml.test. As I'm understand that is a reason why tests foir all other architectures in this file use pre-canned binaries.
> There is no risk in yaml2obj picking the wrong yaml block. You can use the --docnum=<index> switch to specify which one to use, where <index> indicates which doc to use (e.g. --docnum=1 for the first, --docnum=2 for the second etc). See various other examples in the llvm-readobj tests for how.
Now Xtensa test uses yaml2obj instead of pre-built binary

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827