[PATCH] D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects

Wed Feb 12 11:19:39 PST 2020

rriddle marked 2 inline comments as done.
rriddle added a comment.

In D74439#1870934 <https://reviews.llvm.org/D74439#1870934>, @jpienaar wrote:

> Just very quick skim, but could you add tests here already?

I had some spread throughout this revision stack, but I moved/added a bunch here.

================
Comment at: mlir/include/mlir/IR/SideEffects.td:1
+//===- SideEffects.td - Side Effect interfaces -*- tablegen -*-------------===//
+//
----------------
jpienaar wrote:
> Isn't the extra --- normally on the left? https://llvm.org/docs/CodingStandards.html#file-headers
I copied this from one of the other files, I'll have to go back and see which file that was.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74439/new/

https://reviews.llvm.org/D74439